Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/components not reacting to props #2168

Merged
merged 7 commits into from
Jan 25, 2023
Merged

Fix/components not reacting to props #2168

merged 7 commits into from
Jan 25, 2023

Conversation

SavvyShah
Copy link
Contributor

@SavvyShah SavvyShah commented Jan 24, 2023 •
edited

Components don't change when the props passed to them change. Should change majorly when dataField, aggregationSize is changed. Should also change when component specific properties such as data and chartType changes.

Notion Card

ReactiveCore PR

@SavvyShah SavvyShah marked this pull request as ready for review January 24, 2023 10:33
@SavvyShah SavvyShah mentioned this pull request Jan 24, 2023
Merged
@bietkul bietkul merged commit 753b055 into appbaseio:next Jan 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bietkul bietkul bietkul approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@SavvyShah @bietkul