fix(web): searchbox cursor shifts to end in controlled component #2207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SavvyShah
commented
Apr 16, 2023
| * Handles the caret position for input components | ||
| * @param {HTMLInputElement} e | ||
| */ | ||
| export const handleCaretPosition = (e) => { |
There was a problem hiding this comment.
This is no longer referenced in any other file.
SavvyShah
commented
Apr 16, 2023
| @@ -506,9 +518,6 @@ const SearchBox = (props) => { | |||
| if (value === undefined) { | |||
| setValue(inputValue, false, props, undefined, true, false); | |||
| } else if (onChange) { | |||
| // handle caret position in controlled components | |||
| handleCaretPosition(e); | |||
There was a problem hiding this comment.
This didn't have any effect and the cursor still shifted to the end. I suspect that when react version is v17 or lower then only this works.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When SearchBox is used as a controlled component, the cursor shifts to the end while typing in between words.
This happens because:
props.valueis the directly synced value with the input when used as a controlled component.Notion Card
Loom preview attached in notion comments