Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/vue voice search #2215

Merged
merged 3 commits into from
May 11, 2023
Merged

Fix/vue voice search #2215

merged 3 commits into from
May 11, 2023

Conversation

SavvyShah
Copy link
Contributor

Notion card

  • Fix styling issue with mic icon
  • Fix voice search not working

Loom is attached in notion.

@github-actions github-actions bot added the vue label May 1, 2023
@mohdashraf010897 mohdashraf010897 self-requested a review May 10, 2023 05:16
Copy link
Member

@mohdashraf010897 mohdashraf010897 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻

@mohdashraf010897
Copy link
Member

@SavvyShah

The Voice input is somehow limited to at most 2 words, doesn't record the whole speech

https://www.loom.com/share/1d7211fede134c1894f73ee6219cdd2d

Copy link
Member

@mohdashraf010897 mohdashraf010897 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻

@mohdashraf010897 mohdashraf010897 merged commit a570289 into next May 11, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants