web: Improve customization through render props #684
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…renderProps * 'next' of github.com:appbaseio/reactivesearch: next: Add loader prop web: upgrade lifecycle for RangeInput + fix controlled logic for RangeSlider web: upgrade lifecycle + data handling for DynamicRangeSlider web: update RangeSlider prop-types web: update RangeSlider types web: upgrade lifecycle + data handling for RangeSlider web: upgrade lifecycle + data handling for MultiDropdownRange web: upgrade lifecycle + data handling for SingleDropdownRange
metagrover
reviewed
Dec 12, 2018
metagrover
suggested changes
Dec 12, 2018
metagrover
approved these changes
Dec 12, 2018
bietkul
added a commit
that referenced
this pull request
Dec 24, 2018
This PR has the following features/changes :
## Result Components
- Rename `onData` & `onAllData` to `renderData` & `renderAllData` respectively.
- Added `onData` prop callback invoked after data changes, which returns an object with the following properties:
```js
{
results,
streamResults,
loadMore,
base,
triggerClickAnalytics,
}
```
- `renderAllData` also returns the same object.
- Added `renderError (jsx|string|function)` & `onError`
## Search Components
- Merge pull request ( cherry-pick ) #530
- renderSuggestion ( to modify the suggestions, rename the old `onSuggestion` )
- renderAllSuggestion ( Rename `renderSuggestions` )
- onSuggestions
- Added `renderError (jsx|string|function)` & `onError`
## List Components
- Change `renderListItem` to `renderItem`
- Provide `isChecked` property in `renderItem` as a third argument.
```js
renderItem(item.key, item.doc_count, isChecked)
```
- Added `renderError (jsx|string|function)` & `onError`
## Base Components
### Reactive Component
- now supports `onError`
- provides `error` & `isLoading` in props.
### Tag Cloud
- Added `renderError (jsx|string|function)` & `onError`
lakhansamani
pushed a commit
that referenced
this pull request
Apr 8, 2019
This PR has the following features/changes :
## Result Components
- Rename `onData` & `onAllData` to `renderData` & `renderAllData` respectively.
- Added `onData` prop callback invoked after data changes, which returns an object with the following properties:
```js
{
results,
streamResults,
loadMore,
base,
triggerClickAnalytics,
}
```
- `renderAllData` also returns the same object.
- Added `renderError (jsx|string|function)` & `onError`
## Search Components
- Merge pull request ( cherry-pick ) #530
- renderSuggestion ( to modify the suggestions, rename the old `onSuggestion` )
- renderAllSuggestion ( Rename `renderSuggestions` )
- onSuggestions
- Added `renderError (jsx|string|function)` & `onError`
## List Components
- Change `renderListItem` to `renderItem`
- Provide `isChecked` property in `renderItem` as a third argument.
```js
renderItem(item.key, item.doc_count, isChecked)
```
- Added `renderError (jsx|string|function)` & `onError`
## Base Components
### Reactive Component
- now supports `onError`
- provides `error` & `isLoading` in props.
### Tag Cloud
- Added `renderError (jsx|string|function)` & `onError`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has the following features/changes :
Result Components
onData&onAllDatatorenderData&renderAllDatarespectively.onDataprop callback invoked after data changes, which returns an object with the following properties:renderAllDataalso returns the same object.Added
renderError (jsx|string|function)&onErrorSearch Components
onSuggestion)renderSuggestions)renderError (jsx|string|function)&onErrorList Components
renderListItemtorenderItemisCheckedproperty inrenderItemas a third argument.renderError (jsx|string|function)&onErrorBase Components
Reactive Component
onErrorerror&isLoadingin props.Tag Cloud
renderError (jsx|string|function)&onError