Skip to content
This repository has been archived by the owner on Aug 14, 2020. It is now read-only.

use acirenderer? #10

Closed
jonboulle opened this issue Feb 5, 2015 · 0 comments · Fixed by #28
Closed

use acirenderer? #10

jonboulle opened this issue Feb 5, 2015 · 0 comments · Fixed by #28
Assignees

Comments

@jonboulle
Copy link
Contributor

rkt/rkt#464 introduces a library for rendering ACIs from their embedded rootfs and dependencies. Following the discussion in #6 , we should be able to split out this library and leverage it in docker2aci itself. This will probably be blocked on the library moving out of Rocket and upstream into the appc org somewhere (appc/spec? appc/tools?), since it is a general-purpose and not Rocket specific.

@jonboulle jonboulle mentioned this issue Feb 5, 2015
@iaguis iaguis mentioned this issue Feb 5, 2015
iaguis added a commit to endocode/docker2aci that referenced this issue Mar 5, 2015
This commit leverages acirenderer from the spec repository to implement
squashing. This has the benefit of reusing the same code rocket uses for
resolving ACI dependencies.

We create a conversion store that implements the ACIRegistry
interface so we can use the rendering functions.

Resolves appc#10.
@philips philips closed this as completed Mar 6, 2015
iaguis added a commit to endocode/docker2aci that referenced this issue Mar 6, 2015
This commit leverages acirenderer from the spec repository to implement
squashing. This has the benefit of reusing the same code rocket uses for
resolving ACI dependencies.

We create a conversion store that implements the ACIRegistry
interface so we can use the rendering functions.

Resolves appc#10.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants