Skip to content
This repository has been archived by the owner on Aug 14, 2020. It is now read-only.

Godeps: vendor dependencies #128

Merged
merged 2 commits into from
Mar 7, 2016

Conversation

iaguis
Copy link
Member

@iaguis iaguis commented Mar 7, 2016

Now that we're all serious and want to do releases, let's [brace yourselves] use godep to build docker2aci reproducibly.

@krnowak
Copy link
Member

krnowak commented Mar 7, 2016

{braces}

Also, are you sure about 1.0.0? That's basically promising that we won't change API incompatibly.

@jonboulle
Copy link
Contributor

Yeah, I think definitely a pre-1.0.0 version. appc isn't 1.0 yet...

@iaguis
Copy link
Member Author

iaguis commented Mar 7, 2016

0.1.0? 0.7.4? 0.9.0?

@jonboulle
Copy link
Contributor

0.1.0 or 0.9.0 No point in mimicking the spec version as we tried to do in
rkt, since the release cadences with the spec are so out of sync.

On Mon, Mar 7, 2016 at 12:27 PM, Iago López Galeiras <
notifications@github.com> wrote:

0.1.0? 0.7.4? 0.9.0?


Reply to this email directly or view it on GitHub
#128 (comment).

@iaguis
Copy link
Member Author

iaguis commented Mar 7, 2016

👍

@iaguis iaguis mentioned this pull request Mar 7, 2016
@krnowak
Copy link
Member

krnowak commented Mar 7, 2016

Second commit LFAD. First commit probably ok, all the changes are in Godeps directory.

@iaguis
Copy link
Member Author

iaguis commented Mar 7, 2016

I put my trust in godep

iaguis added a commit that referenced this pull request Mar 7, 2016
@iaguis iaguis merged commit 83994e8 into appc:master Mar 7, 2016
@iaguis iaguis mentioned this pull request Mar 10, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants