This repository has been archived by the owner on Aug 14, 2020. It is now read-only.
spec: remove TODOs, fix block isolators #279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| #### resource/block-iops | ||
|
|
||
| * Scope: app/pod | ||
|
|
||
| **Parameters:** | ||
| * **default** must be set to true and means that this bandwidth limit applies to all interfaces except localhost by default. | ||
| * **devicePaths** the block devices that this limit will be placed on |
There was a problem hiding this comment.
this was an accident right?
|
lgtm! |
jonboulle
added a commit
that referenced
this pull request
Apr 1, 2015
spec: remove TODOs, fix block isolators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace TODOs in spec text with GitHub issues:
Change block isolator wording to apply to specific devices (looks like
previous situation was copypastaed from network isolators)