Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TIMOB-15741] Making ios-sim work with Xcode 5.1 #7

Merged
merged 8 commits into from
Feb 14, 2014

Conversation

srahim
Copy link

@srahim srahim commented Feb 14, 2014

Code Review only

Functional testing on timob PR.

@vishalduggal
Copy link

Code reviewed. ACCEPTED

"-Wl,-rpath",
"-Wl,$(DEVELOPER_DIR)/../OtherFrameworks",
);
OTHER_LDFLAGS = "";
PREBINDING = NO;
SDKROOT = "";
VALID_ARCHS = "i386 x86_64";

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is i386 a valid arch for the DVT Framework.

@vishalduggal
Copy link

Code Looks good. Some issues with the project config. Will accept once addressed.

@vishalduggal
Copy link

Code Reviewed. ACCEPTED

@vishalduggal
Copy link

FR Passed.
tidev/titanium-sdk#5350

vishalduggal added a commit that referenced this pull request Feb 14, 2014
[TIMOB-15741] Making ios-sim work with Xcode 5.1
@vishalduggal vishalduggal merged commit 999cdad into appcelerator-archive:master Feb 14, 2014
@farfromrefug
Copy link

I am not sure when it comes from exactly, but somewhere along those lines '--exit' support got broken.
I use a hook just like here not to restart the simulator on every run.
It worked great before that PR, now if the sim is already running i get a black screen when running a project.
Will try and take a look at it

@srahim
Copy link
Author

srahim commented Feb 18, 2014

@farfromrefug i just tested out the --exit flag. It seems to work fine for me. The expected behavior is that this would launch the app and exit from iossim application , but the simulator would still be up. Please do let us know if you still continue to experience this issue.

@farfromrefug
Copy link

@srahim Ok so i got the behavior or --exit, wrong. Actually there is never a point to use this one then as we wouldn't get the log!
So my problem is unrelated to that option. Let me explain. Right now every time you run a project the Ti run.js hook will first kill the simulator then start it again.
I can be long and quite painful, so following the example in the link i gave you, i modified a few month back, the run.js hook to add an option NOT to kill the simulator everytime
You can see my hook here
It worked great until the last modification on the ios-sim and especially (i guess) that PR. Now if the simulator is already running i end up with a black screen.

I should mention now that you helped me that i wrongly use --exit there. I really thought it was to actually kill the app without killing the simulator.

Also i am using XCOde 5.0.2 on Mountain Lion. Did not upgrade yet.

I am really willing to help but i am not sure where to look in the code.
Do you know if there is a part of the code responsible for killing the app process and not the sim process? Or maybe that's just what i should do, kill the app process!

@farfromrefug
Copy link

@srahim Ok so after actually answering you i got my answer. I dont why it was working before, but now it got the right way to do it by killing the app process. So no fix needed in ios-sim.
I am sorry for bugging you with you with you.

Yet if you are interested by the "restartSimulator" option, here is the commit related to it
Akylas/titanium_mobile@ecbc928

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants