-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TIMOB-15741] Making ios-sim work with Xcode 5.1 #7
Conversation
Code reviewed. ACCEPTED |
"-Wl,-rpath", | ||
"-Wl,$(DEVELOPER_DIR)/../OtherFrameworks", | ||
); | ||
OTHER_LDFLAGS = ""; | ||
PREBINDING = NO; | ||
SDKROOT = ""; | ||
VALID_ARCHS = "i386 x86_64"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is i386 a valid arch for the DVT Framework.
Code Looks good. Some issues with the project config. Will accept once addressed. |
Code Reviewed. ACCEPTED |
FR Passed. |
[TIMOB-15741] Making ios-sim work with Xcode 5.1
I am not sure when it comes from exactly, but somewhere along those lines '--exit' support got broken. |
@farfromrefug i just tested out the |
@srahim Ok so i got the behavior or --exit, wrong. Actually there is never a point to use this one then as we wouldn't get the log! I should mention now that you helped me that i wrongly use --exit there. I really thought it was to actually kill the app without killing the simulator. Also i am using XCOde 5.0.2 on Mountain Lion. Did not upgrade yet. I am really willing to help but i am not sure where to look in the code. |
@srahim Ok so after actually answering you i got my answer. I dont why it was working before, but now it got the right way to do it by killing the app process. So no fix needed in ios-sim. Yet if you are interested by the "restartSimulator" option, here is the commit related to it Thanks |
Code Review only
Functional testing on timob PR.