Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timob 15017 Support for skipped blocks #244

Merged
merged 16 commits into from
Sep 18, 2013
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
## New Features
* Implemented a proper CLI hook
* Unit tests now use RPC+Bonjour so that multiple systems can be combined to run unit tests faster
* Implemented support for properly analyzing skipped blocks, improving the accuracy of results considerably

### Bug Fixes
* Fixed regressions introduced when the CLI was overhauled for 3.2.0
Expand Down
6 changes: 1 addition & 5 deletions commands/analyze.js
Original file line number Diff line number Diff line change
Expand Up @@ -413,11 +413,7 @@ function validateCLIParameters(logger, config, cli, callback) {
ti.validateTiappXml(logger, cli.tiapp);

// Note: we do custom SDK validation because the validateCorrectSDK method does a lot more than we need
sdk = cli.tiapp['sdk-version'] || activeSDK;

if (!sdk) {
process.exit(1);
}
sdk = cli.tiapp['sdk-version'] || Object.keys(cli.env.sdks).sort().reverse()[0];

// check the project's preferred sdk is even installed
if (sdk == '__global__' || !cli.env.sdks[sdk]) {
Expand Down