Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TIMOB-25827] Error when fresh install with forceUnInstall #84

Merged
merged 1 commit into from
Mar 5, 2018
Merged

[TIMOB-25827] Error when fresh install with forceUnInstall #84

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
0.6.5 (02/03/2018)
* [TIMOB-25827] Fix error when fresh install with forceUnInstall
0.6.4 (19/12/2017)
* [TIMOB-25616] Don't forceUnInstall unless user explicitly specifies it
0.6.3 (27/11/2017)
Expand Down
8 changes: 6 additions & 2 deletions lib/wptool.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -903,15 +903,19 @@ function wpToolInstall(deployCmd, device, appPath, options, callback) {
if (code) {
// handle duplicate package identity error code from Windows 10.0.14393 tooling and above
if (code == '2148734208') {
if (out.indexOf('because the current user does not have that package installed') == -1) {
if (out.indexOf('0x80131500 - Failed to install or update package: Unspecified error') != -1) {
// handle duplicate package identity error code from Windows 10.0.14393 tooling and above
callback(new Error('A debug application is already installed, please remove existing debug application.'));
} else if (out.indexOf('because the current user does not have that package installed') == -1) {
if (options.forceUnInstall) {
wpToolInstall(deployCmd, device, appPath, options, callback);
} else {
callback(new Error('A debug application is already installed. Please increment the version number of the application, or use forceUnInstall option to explicitly delete existing app.'));
}
} else {
// Windows cannot remove the app because the current user does not have that package installed.
callback(new Error('A debug application is already installed, please remove existing debug application'));
options.forceUnInstall = false;
wpToolInstall(deployCmd, device, appPath, options, callback);
}
} else {
var errmsg = out.trim().split(/\r\n|\n/).shift(),
Expand Down
2 changes: 1 addition & 1 deletion package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "windowslib",
"version": "0.6.4",
"version": "0.6.5",
"description": "Windows Phone Utility Library",
"keywords": [
"appcelerator",
Expand Down