[TIMOB-12218] Adding test case for significanttimechange event
#88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gal/ks_window_prop_fix True restoration of background color on Toggle Height/Width
…gal/timob-11315 [TIMOB-11315] Add Action Bar to KS
| Titanium.App.addEventListener('significanttimechange',function(e) | ||
| { | ||
| Ti.API.info("Time Change Event Received !! "); | ||
| paused = true; |
There was a problem hiding this comment.
why is this set to true? The event can be received when the app is in foreground.
|
Code reviewed. One minor point. Otherwise looks good. |
|
FR also failed. When the screen first loads up, the two text labels overlap. Perhaps wrap them in a view with a vertical layout and add the view to the window. |
|
Noticed that on the simulator, the event is fired multiple times. Remove the alert because it is annoying. But the good news, I actually got the notification |
|
Sorry had some code from the copied over section. Cleaned up the code. Ready for review. |
|
Closing out PR as it is picking up older commits. Will make a new PR . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To be tested along with TIMOB PR
GO TO PLATFORM > APPLICATION EVENTS
Background the app.
Change the time zone.(Settings > General > Date & Time > timezone)
Resume the app. You should see the Label change and an alert being fired.