Migrate to gradle build system. #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
I think #112 should be considered before this one, seeing as it may impact things. |
|
@sgtcoolguy, agreed. How about we go ahead and merge PR #112 and then test Android/iOS based on this PRs final changes? |
garymathews
force-pushed
the
migrate_to_gradle
branch
from
43dff04
to
afc114b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA:
https://jira.appcelerator.org/browse/MOD-2563
Note:
I tried to get update to using AndroidX in the source files, but unfortunately it is not only a namespace change. I think it will bloat unnecessary this task and it will be for the best if we separate an update in another one.