New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(android): migrate to gradle #114
Conversation
- Set min Titanium SDK version to 9.0.0. - Added x86_64 architecture support. - Updated Facebook library to 5.13.0
New dependencies added: @seadub/danger-plugin-titanium-moduleAuthor: Chris Williams Description: Eslint your code with Danger Homepage: https://github.com/sgtcoolguy/danger-plugin-titanium-module#readme
|
@jquick-axway I opened jquick-axway#1 to fix the deprecations (actually logged as errors in the build right now, although only warnings). The removed methods have been deprecated since a while and the |
chore(android): replace/remove deprecated api’s
Thanks @hansemannn. I merged your changes into this PR. |
loginButton.setPublishPermissions(Arrays.asList(publishPermissions)); | ||
} | ||
Log.w(TAG, | ||
"The \"publishPermissions\" property has been deprecated in favor of the \"permissions\" property"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Logic for publishPermissions
and readPermissions
needs re-adding. Since these changes remove these properties and not deprecate them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@garymathews They are actually removed in the native SDK already (no-op functions natively), but it can be added again I think. On iOS (merged on master), it's the same behavior as here right now I think.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can just pass to
loginButton.setPermissions(Arrays.asList(...));
But if we can't, then I guess we can just update the log message to state it's been removed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated PR to merge deprecated publishPermissions
and readPermissions
property arrays to the main non-deprecated permissions
collection/method. Kept the logged warnings. There's slight duplication in the module's Java propertyChanged()
method, but I think we can live with it for now... until we remove them later.
- Permission properties "publishPermissions" and "readPermissions" have been deprecated by Facebook. * Now routed to LoginButton's main permissions() method, but will log a warning when used.
FR Passed. Module Ver: 9.0.0 |
I'm cherry-picking and squashing the iOS fix from #104 into this PR so that they can be built together (and versioned/released together) |
JIRA:
https://jira.appcelerator.org/browse/TIMOB-27725
Summary:
9.0.0
.x86_64
architecture support.5.4.0
to5.13.0
.InviteDialog
.onAppCreate()
method.ContentProvider
.LoginButton
propertiespublishPermissions
andreadPermissions
have been deprecated.permissions
property instead.