Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(android): migrate to gradle #114

Merged
merged 12 commits into from Feb 3, 2020
Merged

Conversation

jquick-axway
Copy link
Contributor

@jquick-axway jquick-axway commented Jan 24, 2020

JIRA:
https://jira.appcelerator.org/browse/TIMOB-27725

Summary:

  • Now builds with gradle to an "AAR" library.
  • Set min Titanium SDK version to 9.0.0.
  • Added x86_64 architecture support.
  • Updated Facebook library version from 5.4.0 to 5.13.0.
  • Removed deprecated InviteDialog.
    • No longer works. See: here
  • Removed module's onAppCreate() method.
    • Facebook's SDK initializer was deprecated. Now auto-inits via ContentProvider.
  • LoginButton properties publishPermissions and readPermissions have been deprecated.
    • Must use permissions property instead.

- Set min Titanium SDK version to 9.0.0.
- Added x86_64 architecture support.
- Updated Facebook library to 5.13.0
@build
Copy link

build commented Jan 24, 2020

Fails
🚫 version bump was Patch in ios/manifest but Major in package.json
Warnings
⚠️ guid is inconsistent across platforms. It is e4f7ac61-1ee7-44c5-bc27-fa6876e2dce9 in android/manifest and da8acc57-8673-4692-9282-e3c1a21f5d83 in ios/manifest
⚠️ SDK version declared in Jenkinsfile (9.0.0.v20200127103011) does not match iOS' titanium.xcconfig value (9.0.0.GA)
Messages
📖

💾 Here are the artifacts produced:

📖

✅ All tests are passing
Nice one! All 112 tests are passing.

📖 🎉 - congrats on your new release

New dependencies added: @seadub/danger-plugin-titanium-module.

@seadub/danger-plugin-titanium-module

Author: Chris Williams

Description: Eslint your code with Danger

Homepage: https://github.com/sgtcoolguy/danger-plugin-titanium-module#readme

Created3 days ago
Last Updatedabout 1 hour ago
LicenseMIT
Maintainers1
Releases4
Direct Dependenciesfs-extra and semver
Keywordsdanger, danger-plugin and eslint
README

danger-plugin-titanium-module

npm version
semantic-release

Eslint your code with Danger

Usage

Install:

yarn add danger-plugin-titanium-module --dev
# OR
npm install danger-plugin-titanium-module -D

At a glance:

// dangerfile.js
import lint from 'danger-plugin-titanium-module'

await lint()

Changelog

See the GitHub release history.

Contributing

See CONTRIBUTING.md.

Generated by 🚫 dangerJS against 7eb5f47

@hansemannn
Copy link
Contributor

@jquick-axway I opened jquick-axway#1 to fix the deprecations (actually logged as errors in the build right now, although only warnings). The removed methods have been deprecated since a while and the readPermissions / writePermissions have been replaced on iOS in #103.

chore(android): replace/remove deprecated api’s
@jquick-axway
Copy link
Contributor Author

Thanks @hansemannn. I merged your changes into this PR.

loginButton.setPublishPermissions(Arrays.asList(publishPermissions));
}
Log.w(TAG,
"The \"publishPermissions\" property has been deprecated in favor of the \"permissions\" property");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logic for publishPermissions and readPermissions needs re-adding. Since these changes remove these properties and not deprecate them.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@garymathews They are actually removed in the native SDK already (no-op functions natively), but it can be added again I think. On iOS (merged on master), it's the same behavior as here right now I think.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can just pass to

loginButton.setPermissions(Arrays.asList(...));

But if we can't, then I guess we can just update the log message to state it's been removed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated PR to merge deprecated publishPermissions and readPermissions property arrays to the main non-deprecated permissions collection/method. Kept the logged warnings. There's slight duplication in the module's Java propertyChanged() method, but I think we can live with it for now... until we remove them later.

- Permission properties "publishPermissions" and "readPermissions" have been deprecated by Facebook.
  * Now routed to LoginButton's main permissions() method, but will log a warning when used.
@lokeshchdhry
Copy link

FR Passed.

Module Ver: 9.0.0

@sgtcoolguy
Copy link
Contributor

I'm cherry-picking and squashing the iOS fix from #104 into this PR so that they can be built together (and versioned/released together)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants