feat: update Facebook SDK to 5.x, fix iOS 13 login crash #103
Conversation
…acebook into feature/fb-sdk-5.0.0 # Conflicts: # ios/Classes/Messenger Button/FacebookMessengerButton.h # ios/Classes/Messenger Button/FacebookMessengerButton.m # ios/Classes/Messenger Button/FacebookMessengerButtonProxy.m # ios/titanium.xcconfig
Dependencies with modified semantic versioning:
|
hansemannn
changed the title
|
@vijaysingh-axway @janvennemann Can someone review this? We use it in production since ages. |
hansemannn
changed the title
|
@vijaysingh-axway Another ping to include this to 8.2.0 so FB apps continue to work |
|
@sgtcoolguy Build is failing due to "[ERROR] : �� �Unable to find any Xcode installations that supports iOS Simulator 13.0.". I guess need to use XCode 11 here as well. |
|
@vijaysingh-axway The build issue is not module related and was fixed in ioslib 1.7.9+. I hope this can be merged |
|
I think it failed because it tried to build on an Xcode 11 beta 6 node with SDK 7.5.2.GA which doesn't work with Xcode 11. I'm updating the PR to try to build against 8.1.0.GA and see if that helps. |
|
Well we're getting closer. Now the iOS tests are hanging - and the karma runner doesn't really surface the logs as the app runs, so it's hard to tell what's going on. Maybe @janvennemann knows? |
| @@ -16,6 +16,7 @@ | |||
| #import "TiBase.h" | |||
| #import "TiHost.h" | |||
| #import "TiUtils.h" | |||
| #import "TiBlob.h" | |||
There was a problem hiding this comment.
I'm curious why this does not cause issues for us right now. Maybe it works if the symbol is linked by other modules? Good catch in any case!
|
I think ultimately our attempts to retain backwards compatibility were infeasible, so we'll go with this original PR where we bump the major version on iOS and break backwards compatibility - since Facebook has essentially killed off the messenger button. One note: I think e should then remove the messenger button code from the example app inside the module here. |
|
FR Passed. Tested with Kitchensink apps Facebook and example app in facebook module.Login with facebook ,sharing and logout functionality works fine. Test Environment: |
JIRA: https://jira.appcelerator.org/browse/MOD-2534
iOS and Android are working, docs have been updated. Ready for review!
Native SDK builds: