Added logPurchase support #16
Conversation
|
@Protossoario Thanks for the PR. Before we could review this, could you sign the CLA? |
|
Also, could you undo/remove the file change of android/build.properties.example → android/build.properties. Thank you! |
Protossoario
force-pushed
the
master
branch
2 times, most recently
from
e3637c9
to
713ad5d
Compare
|
I successfully removed the change of build.properties.example and signed the CLA! |
|
@Protossoario sorry to bother you again. The auto check didn't show your github account as signed. Did you sign it here https://cla.appcelerator.com/ or another location? Also, could you rebase/merge all the commits into one? Seems like some other commit history came along with it after you removed that file. If you could do this on this branch http://makandracards.com/makandra/527-squash-several-git-commits-into-a-single-commit (Easy mode: Reset your feature branch to the master state) and then force push the updated branch, that would be awesome! Sorry for the request! And thanks again! |
|
Thanks for the link! It was really easy to do the reset with the instructions on that page and the pull request should be a lot cleaner now. As for the CLA, I can't seem to sign it. I try clicking the "Sign in with GitHub" button, but it keeps redirecting me to the same page over and over. |
|
@Protossoario thanks! With regards to the CLA, could you try again? Perhaps it's something to do with your Github settings... |
|
Finally! It seems there was an issue with Chrome which was preventing me from signing the CLA. I tried with Safari and it finally worked just fine. |
|
@ashcoding Can we tackle this one? We will also need docs updates here, would be great if @Protossoario could provide them! :-) |
|
@hansemannn Yup. This is okay. |
|
@Protossoario Any update here? Has been some more months now. As the code currently also has merge problems, please also rebase your PR to ensure the continuous integration. Also think of the docs. Thank you! |
|
Finally resolved all merge conflicts, added the iOS implementation, docs, JIRA-ticket and example. Closing in favor of: #49 |
Allows users to log purchases through the Facebook SDK specifying the currency