Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MOD-2244] iOS / Android: Support "logPurchase" #49

Merged
merged 6 commits into from
Apr 25, 2016

Conversation

hansemannn
Copy link
Contributor

Protossoario and others added 2 commits April 17, 2016 14:29
Signed-off-by: Hans Knoechel <hans.knoechel@hs-osnabrueck.de>

# Conflicts:
#	android/src/facebook/TiFacebookModule.java
Signed-off-by: Hans Knoechel <hans.knoechel@hs-osnabrueck.de>
@hansemannn hansemannn changed the title [MOD-2244] iOS / Android: Support "logPurchase" in Ti.Facebook [MOD-2244] iOS / Android: Support "logPurchase" Apr 17, 2016
Signed-off-by: Hans Knoechel <hans.knoechel@hs-osnabrueck.de>
@@ -131,7 +137,8 @@ The proxy object must be created prior to calling open() on the window or tabgro
This proxy has no APIs (new since version 3.20.05), its sole function is to signal the Facebook SDK for the various Activity transitions. So just create it and attach it to the window/tabgroup.

Facebook Login and Authorization
--------------------------------
---

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Accidentally added 2 lines ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, removed 134 (red) and added 140/141 (green)

@AngelkPetkov
Copy link
Contributor

CR looks good , FT did not work, nothing is being logged when you run the method.

@hansemannn
Copy link
Contributor Author

The method is not supposed to log something in your console, it's supposed to log something in the Facebook App Portal (developers.facebook.com). Please configure an a new Facebook app there, link it in the tiapp.xml like in the KitchenSink and run it from there. I'm very sure it works.

@AngelkPetkov
Copy link
Contributor

I set up a Facebook developer account and a new app. Then moved all the properties needed to the tiaapp,xml to login in to my app. However the logs don't seem to work, on the developer portal i can see that I've installed the app, however they are no logs that i can find.

@hansemannn
Copy link
Contributor Author

Just validated it yesterday. The data does not show up directly, because the Facebook API seems to queue it asynchronous, but as I checked today, it was successfully logged. See this URL:

https://www.facebook.com/analytics/<FB_APP_ID>/?section=revenue

@AngelkPetkov
Copy link
Contributor

Good job, FT passed, Approved!

@AngelkPetkov AngelkPetkov merged commit 7b10838 into tidev:master Apr 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants