[TIMOB-25353] Android: Use ti.playservices module #216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hansemannn
reviewed
Oct 20, 2017
android/timodule.xml
Outdated
| </mobileweb> | ||
| <modules> | ||
| <module platform="android">ti.playservices</module> | ||
| </modules>> |
There was a problem hiding this comment.
Good catch! It still worked 👍
|
@garymathews I think you'll need to update the sdk used to build this to be |
|
@sgtcoolguy The build fails due to this change which looks to be added recently: [ERROR] : �� �Failed to run command "build"
[ERROR] : � �TypeError: Path must be a string. Received 0
at assertPath (path.js:7:11)
at Object.join (path.js:1218:7)
at AndroidModuleBuilder.obtainModuleDependency (/Users/build/Library/Application Support/Titanium/mobilesdk/osx/7.0.0.v20171110073543/android/cli/commands/_buildModule.js:327:19)
at Array.forEach (native)
at AndroidModuleBuilder.initialize (/Users/build/Library/Application Support/Titanium/mobilesdk/osx/7.0.0.v20171110073543/android/cli/commands/_buildModule.js:338:53)
at /Users/build/Library/Application Support/Titanium/mobilesdk/osx/7.0.0.v20171110073543/node_modules/async/dist/async.js:3816:26
at replenish (/Users/build/Library/Application Support/Titanium/mobilesdk/osx/7.0.0.v20171110073543/node_modules/async/dist/async.js:982:17)
at iterateeCallback (/Users/build/Library/Application Support/Titanium/mobilesdk/osx/7.0.0.v20171110073543/node_modules/async/dist/async.js:967:17)
at /Users/build/Library/Application Support/Titanium/mobilesdk/osx/7.0.0.v20171110073543/node_modules/async/dist/async.js:944:16
at /Users/build/Library/Application Support/Titanium/mobilesdk/osx/7.0.0.v20171110073543/node_modules/async/dist/async.js:3821:13
at apply (/Users/build/Library/Application Support/Titanium/mobilesdk/osx/7.0.0.v20171110073543/node_modules/async/dist/async.js:21:25)
at /Users/build/Library/Application Support/Titanium/mobilesdk/osx/7.0.0.v20171110073543/node_modules/async/dist/async.js:56:12
at AndroidModuleBuilder.doAnalytics (/Users/build/Library/Application Support/Titanium/mobilesdk/osx/7.0.0.v20171110073543/android/cli/commands/_buildModule.js:259:2)
at /Users/build/Library/Application Support/Titanium/mobilesdk/osx/7.0.0.v20171110073543/node_modules/async/dist/async.js:3816:26
at replenish (/Users/build/Library/Application Support/Titanium/mobilesdk/osx/7.0.0.v20171110073543/node_modules/async/dist/async.js:982:17)
at iterateeCallback (/Users/build/Library/Application Support/Titanium/mobilesdk/osx/7.0.0.v20171110073543/node_modules/async/dist/async.js:967:17) |
jvandijk
pushed a commit
to jvandijk/ti.map
that referenced
this pull request
Nov 20, 2017
…feature/parity-on-addpolylines-implementation * 'master' of github.com:appcelerator-modules/ti.map: [TIMOB-25353] Android: Use ti.playservices module (tidev#216) [MOD-2371] Fix selectedAnnotation regression
jvandijk
pushed a commit
to jvandijk/ti.map
that referenced
this pull request
Feb 3, 2018
* master: Update Jenkinsfile Move all sources to Classes directory Update project.pbxproj [TIMOB-25677] Fix cluster-annotations-crash and static analyser warnings [MOD-2378] Bump version to 4.1.1 [MOD-2378] Fix Annotation memory leak Update changelog.md Update changelog.md Update changelog.md Update manifest Update Jenkinsfile Fix copy & paste error, use handleAddPolylines [TIMOB-25353] Android: Use ti.playservices module (tidev#216) [MOD-2371] Fix selectedAnnotation regression Bump the version number Add addPolylines proxy method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ti.playservicesmoduleti.map-4.0.0
JIRA Ticket