Skip to content

Commit

Permalink
Merge branch 'master' of github.com:appcelerator-modules/ti.map into …
Browse files Browse the repository at this point in the history
…feature/parity-on-addpolylines-implementation

* 'master' of github.com:appcelerator-modules/ti.map:
  [TIMOB-25353] Android: Use ti.playservices module (tidev#216)
  [MOD-2371] Fix selectedAnnotation regression
  • Loading branch information
Jeroen van Dijk committed Nov 20, 2017
2 parents c77c388 + d331c16 commit 0e38178
Show file tree
Hide file tree
Showing 28 changed files with 18 additions and 31 deletions.
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -28,5 +28,6 @@ android/.classpath
android/.settings
android/dist/
android/launch-*
android/java-sources.txt
nbproject
/ios/metadata.json
3 changes: 2 additions & 1 deletion Jenkinsfile
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
buildModule {
// defaults:
//nodeVersion = '4.7.3' // Must have version set up on Jenkins master before it can be changed
//sdkVersion = '6.0.3.GA'
// TODO: Change to 7.0.0.GA after release
sdkVersion = '7.0.0.v20171110104246' // Use latest master build with ti.playservices included and fixes to module build.
//androidAPILevel = '23' // if changed, must install on build nodes
}
Binary file removed android/lib/google-play-services-base.jar
Binary file not shown.
Binary file removed android/lib/google-play-services-basement.jar
Binary file not shown.
Binary file removed android/lib/google-play-services-map.jar
Binary file not shown.
1 change: 0 additions & 1 deletion android/lib/version

This file was deleted.

10 changes: 5 additions & 5 deletions android/manifest
Original file line number Diff line number Diff line change
Expand Up @@ -2,19 +2,19 @@
# this is your module manifest and used by Titanium
# during compilation, packaging, distribution, etc.
#
version: 3.4.0
apiversion: 3
architectures: armeabi-v7a x86
version: 4.0.0
apiversion: 4
architectures: arm64-v8a armeabi-v7a x86
description: External version of Map module to support new Google Map v2 sdk
author: Hieu Pham
license: Apache Public License v2
copyright: Copyright (c) 2013-2017 by Appcelerator, Inc.
copyright: Copyright (c) 2013-2017 by Axway, Inc.


# these should not be edited
name: map
moduleid: ti.map
guid: f0d8fd44-86d2-4730-b67d-bd454577aeee
platform: android
minsdk: 6.0.0
minsdk: 7.0.0
respackage: com.google.android.gms
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
31 changes: 9 additions & 22 deletions android/timodule.xml
Original file line number Diff line number Diff line change
@@ -1,27 +1,14 @@
<?xml version="1.0" encoding="UTF-8"?>
<ti:module xmlns:ti="http://ti.appcelerator.org" xmlns:android="http://schemas.android.com/apk/res/android">
<!--
Similar to tiapp.xml, but contains module/platform specific
configuration in <iphone>, <android>, and <mobileweb> sections
-->
<iphone>
</iphone>
<android xmlns:android="http://schemas.android.com/apk/res/android">
<manifest>
<uses-feature android:glEsVersion="0x00020000" android:required="true"/>
<permission android:name="${tiapp.properties['id']}.permission.MAPS_RECEIVE" android:protectionLevel="signature"/>
<uses-permission android:name="com.google.android.providers.gsf.permission.READ_GSERVICES"/>
<uses-permission android:name="${tiapp.properties['id']}.permission.MAPS_RECEIVE"/>
<uses-permission android:name="android.permission.ACCESS_COARSE_LOCATION"/>
<uses-permission android:name="android.permission.ACCESS_FINE_LOCATION"/>
<application>
<meta-data
android:name="com.google.android.gms.version"
android:value="@integer/google_play_services_version"/>
</application>
</manifest>

<manifest>
<uses-feature android:glEsVersion="0x00020000" android:required="true"/>
<uses-permission android:name="${tiapp.properties['id']}.permission.MAPS_RECEIVE"/>
<uses-permission android:name="android.permission.ACCESS_COARSE_LOCATION"/>
<uses-permission android:name="android.permission.ACCESS_FINE_LOCATION"/>
</manifest>
</android>
<mobileweb>
</mobileweb>
<modules>
<module platform="android">ti.playservices</module>
</modules>
</ti:module>
1 change: 0 additions & 1 deletion ios/Classes/TiMapView.m
Original file line number Diff line number Diff line change
Expand Up @@ -982,7 +982,6 @@ - (void)mapView:(MKMapView *)mapView didSelectAnnotationView:(MKAnnotationView *
BOOL isSelected = [view isSelected];
MKAnnotationView<TiMapAnnotation> *ann = (MKAnnotationView<TiMapAnnotation> *)view;

RELEASE_TO_NIL(selectedAnnotation);
selectedAnnotation = [ann retain];

// If canShowCallout == true we will try to find calloutView to hadleTap on callout
Expand Down
2 changes: 1 addition & 1 deletion ios/manifest
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
# this is your module manifest and used by Titanium
# during compilation, packaging, distribution, etc.
#
version: 3.0.0
version: 3.0.1
apiversion: 2
architectures: armv7 arm64 i386 x86_64
description: External version of Map module
Expand Down

0 comments on commit 0e38178

Please sign in to comment.