Timob 16180 3: Add snapshot support #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… into timob-16180-3 Conflicts: android/src/ti/map/TiUIMapView.java android/src/ti/map/ViewProxy.java
| KrollDict data = new KrollDict(); | ||
| data.put("snapshot", sblob); | ||
| data.put("source", proxy); | ||
| proxy.fireEvent("onsnapshotready", data); |
There was a problem hiding this comment.
It's better to use a constant instead of "onsnapshotready".
There was a problem hiding this comment.
its only used once, no need for constant
There was a problem hiding this comment.
But it will make the search easier if someone wants to know where the event is fired.
|
Code reviewed and functionally tested. Looks good except one minor comment. |
jonalter
added a commit
that referenced
this pull request
Jan 24, 2014
Timob 16180 3: Add snapshot support
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Run example/3d.js, click on snapshot button.