-
-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Timob 16180 3: Add snapshot support #32
Conversation
… into timob-16180-3 Conflicts: android/src/ti/map/TiUIMapView.java android/src/ti/map/ViewProxy.java
KrollDict data = new KrollDict(); | ||
data.put("snapshot", sblob); | ||
data.put("source", proxy); | ||
proxy.fireEvent("onsnapshotready", data); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's better to use a constant instead of "onsnapshotready".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
its only used once, no need for constant
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But it will make the search easier if someone wants to know where the event is fired.
Code reviewed and functionally tested. Looks good except one minor comment. |
Timob 16180 3: Add snapshot support
Run example/3d.js, click on snapshot button.