Make window-options and callback-url configurable #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgtcoolguy
requested changes
Apr 13, 2017
There was a problem hiding this comment.
So I think this change is good for the long-term, but I see that it doesn't actually work as expected (by the failed test). And it raises the issue that isgnoreSslError likely also fails.
You're moving them to be properties on an instance of OAuth. The methods they're used within are not instance/prototype methods, but are "static"/class-level methods. So this.callbackUrl, this.ignoreSslError and this.authWindow are all undefined.
| @@ -108,6 +97,12 @@ var OAuth = function OAuth(clientId) { | |||
| this.tokenType = null; | |||
| this.expiresIn = 0; | |||
| this.ignoreSslError = false; | |||
| this.callbackUrl = 'http://localhost/Callback'; // FIXME: We should remove this in the next major release, keeping for backwards compatibility. | |||
| @@ -221,7 +216,7 @@ OAuth.authorizeImplicitly = function(url, clientId, scopes, callback) { | |||
| url : buildURL(url, { | |||
| scope: scopes, | |||
| approval_prompt: 'force', | |||
| redirect_uri: CALLBACK_URL, | |||
| redirect_uri: this.callbackUrl, | |||
There was a problem hiding this comment.
...here it's undefined!
|
Closed in favor of #7 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: https://jira.appcelerator.org/browse/TIMOB-24576
Moving the
AUTH_WINDOW_OPTIONSandCALLBACK_URLto configurable properties of theOAuthclass, trying to keep full backwards-compatibility by specifying default values. We should remove the default callback-url and window title in 1.0.0 and validate the callback-url before it's usage. The check may even be done earlier, please advice @sgtcoolguy 馃檪.