Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(runtime): error when using models with configuration file #882

Merged
merged 2 commits into from Oct 24, 2019
Merged

fix(runtime): error when using models with configuration file #882

merged 2 commits into from Oct 24, 2019

Conversation

feons
Copy link
Contributor

@feons feons commented Mar 7, 2018 •
edited

…thout model configuration file

https://jira.appcelerator.org/browse/ALOY-1598

@ewanharris
Copy link
Contributor

@feons, is this PR still a WIP? Running locally it seems to solve the issue for me

@feons feons requested a review from ewanharris March 19, 2019 18:16
@feons
Copy link
Contributor Author

feons commented Mar 19, 2019

@ewanharris, removed wip and fixed conflict.

@build
Copy link

build commented Mar 19, 2019

Warnings
⚠️

Please ensure to add a changelog entry for your changes. Edit the CHANGELOG.md file and add your change under the Unreleased items header
Messages
📖

✅ All tests are passing
Nice one! All 3470 tests are passing.

Generated by 🚫 dangerJS against f875963

ewanharris
ewanharris approved these changes Oct 24, 2019
View reviewed changes
Copy link
Contributor

@ewanharris ewanharris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Tested across a few of the model samples and appc-sample-databinding and saw no issues

@ewanharris ewanharris changed the title [ALOY-1598] Runtime error when using Backbone Collection and Model wi… fix(runtime): error when using models with configuration file Oct 24, 2019
@ewanharris ewanharris merged commit 0d6a312 into tidev:master Oct 24, 2019
@wv91364210zhuozh wv91364210zhuozh mentioned this pull request Feb 2, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ewanharris ewanharris ewanharris approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@feons @ewanharris @build