fix(runtime): error when using models with configuration file#882
Merged
ewanharris merged 2 commits intotidev:masterfrom Oct 24, 2019
Merged
fix(runtime): error when using models with configuration file#882ewanharris merged 2 commits intotidev:masterfrom
ewanharris merged 2 commits intotidev:masterfrom
Conversation
…thout model configuration file
Member
|
@feons, is this PR still a WIP? Running locally it seems to solve the issue for me |
Contributor
Author
|
@ewanharris, removed wip and fixed conflict. |
ewanharris
approved these changes
Oct 24, 2019
Member
ewanharris
left a comment
ewanharris
left a comment
There was a problem hiding this comment.
Looks good to me!
Tested across a few of the model samples and appc-sample-databinding and saw no issues
ewanharris
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…thout model configuration file
https://jira.appcelerator.org/browse/ALOY-1598