[TIMOB-24057] Always build pods for all archs #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hansemannn
reviewed
Mar 2, 2017
| @@ -540,13 +540,9 @@ function runCocoaPodsBuild (basedir, builder, callback) { | |||
| '-alltargets', | |||
| 'IPHONEOS_DEPLOYMENT_TARGET=' + minSDKVersion, | |||
| '-sdk', sdk, | |||
| 'SYMROOT=' + productsDirectory | |||
| 'SYMROOT=' + productsDirectory, | |||
| 'ONLY_ACTIVE_ARCH=NO' | |||
There was a problem hiding this comment.
Is this the native behavior? I feel like this could cause problems in AppStore submissions having a fat binary.
There was a problem hiding this comment.
This corresponds to the Xcode setting "Build Active Architecture Only" which is set to No by default for the Release configuration in Xcode. So this is the default behavior for AppStore builds. Also as mentioned in my PR descriptions we also do this for the App build anyway. Building only the active architecture speeds up the build process and is used by default in the Xcode Debug configuration. Not sure why we always have this setting to No thought.
|
Approved! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: https://jira.appcelerator.org/browse/TIMOB-24057
Building the pods for a specific arch and the app for all available archs was causing issues during linking. The
ONLY_ACTIVE_ARCH=NOflag is set in the app's Xcode project here so we need to do the same for pods.