Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TIMOB-24057] Always build pods for all archs #123

Merged
merged 1 commit into from
Mar 2, 2017
Merged

[TIMOB-24057] Always build pods for all archs #123

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 2 additions & 6 deletions metabase/ios/lib/metabase.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -540,13 +540,9 @@ function runCocoaPodsBuild (basedir, builder, callback) {
'-alltargets',
'IPHONEOS_DEPLOYMENT_TARGET=' + minSDKVersion,
'-sdk', sdk,
'SYMROOT=' + productsDirectory
'SYMROOT=' + productsDirectory,
'ONLY_ACTIVE_ARCH=NO'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this the native behavior? I feel like this could cause problems in AppStore submissions having a fat binary.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This corresponds to the Xcode setting "Build Active Architecture Only" which is set to No by default for the Release configuration in Xcode. So this is the default behavior for AppStore builds. Also as mentioned in my PR descriptions we also do this for the App build anyway. Building only the active architecture speeds up the build process and is used by default in the Xcode Debug configuration. Not sure why we always have this setting to No thought.

];
if (builder.simHandle) {
// Manually set the arch for simulator builds since we cannot use -destination
// because the Pods project has no scheme.
args.push('-arch', process.arch === 'x64' ? 'x86_64' : 'i386');
}
var buildOutDir = path.join(productsDirectory, buildConfigurationName + '-' + sdkType),
runDir = path.join(basedir, 'Pods'),
child = spawn(xcodesettings.xcodebuild, args, {cwd:runDir});
Expand Down