[TIMOB-25440] Weak link newer frameworks (2_2_X) #262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janvennemann
force-pushed
the
TIMOB-25440-2_2_X
branch
from
3b7f69b
to
d33c177
Compare
Weak link frameworks that were introduced in a later iOS version than our minium deployment target.
janvennemann
force-pushed
the
TIMOB-25440-2_2_X
branch
from
d33c177
to
827db92
Compare
janvennemann
force-pushed
the
TIMOB-25440-2_2_X
branch
from
9cdc256
to
3864fd7
Compare
hansemannn
reviewed
Nov 22, 2017
metabase/ios/src/def.h
Outdated
| @@ -81,6 +81,8 @@ namespace hyperloop { | |||
| inline const std::string getName() const { return name; } | |||
| inline const std::string getFileName() const { return filename; } | |||
| inline const std::string getLine() const { return line; } | |||
| inline const std::string getIntroducedIn() const { return introducedIn; } | |||
| void setIntroducedin(const CXVersion version); | |||
There was a problem hiding this comment.
Should be setIntroducedIn
hansemannn
reviewed
Nov 22, 2017
metabase/ios/src/def.cpp
Outdated
| @@ -115,6 +115,18 @@ namespace hyperloop { | |||
| cursor(_cursor), name(_name), filename(ctx->getCurrentFilename()), line(ctx->getCurrentLine()), context(ctx) { | |||
| } | |||
|
|
|||
| void Definition::setIntroducedin(const CXVersion version) { | |||
hansemannn
approved these changes
Nov 22, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: https://jira.appcelerator.org/browse/TIMOB-25440
Weak link frameworks that were introduced in a later iOS version then our minium deployment target.