Skip to content

Commit

Permalink
[TIMOB-25440] Fix umbrella header detection
Browse files Browse the repository at this point in the history
  • Loading branch information
janvennemann committed Nov 21, 2017
1 parent a3f9498 commit 3864fd7
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions metabase/ios/lib/metabase.js
Original file line number Diff line number Diff line change
Expand Up @@ -633,7 +633,7 @@ function generateFrameworkIncludeMap (frameworkMetadata, includes, callback) {
var umbrellaHeaderRegex = /umbrella header\s"(.+\.h)"/i;
var umbrellaHeaderMatch = moduleMap.match(umbrellaHeaderRegex);
if (umbrellaHeaderMatch !== null) {
frameworkMetadata.umbrellaHeader = path.join(frameworkMetadata.path, umbrellaHeaderMatch[1]);
frameworkMetadata.umbrellaHeader = path.join(frameworkMetadata.path, 'Headers', umbrellaHeaderMatch[1]);
}
util.logger.trace('Objective-C only framework, parsing all header files');
extractImplementationsFromFramework(frameworkName, frameworkPath, includes);
Expand Down Expand Up @@ -682,9 +682,9 @@ function generateCocoaPodsMetadata (cacheDir, builder, settings, callback) {
tasks.push(function (next) {
generateStaticLibrariesIncludeMap(staticLibrariesHeaderPath, includes, () => {
Object.keys(includes).forEach(libraryName => {
// Using a dummy path here since it depends on Xcode env vars which we don't have here
const dummyPath = path.join(staticLibrariesHeaderPath, libraryName);
const moduleMetadata = new ModuleMetadata(libraryName, dummyPath, ModuleMetadata.MODULE_TYPE_STATIC);
const libraryPath = path.join(staticLibrariesHeaderPath, libraryName);
const moduleMetadata = new ModuleMetadata(libraryName, libraryPath, ModuleMetadata.MODULE_TYPE_STATIC);
moduleMetadata.umbrellaHeader = path.join(moduleMetadata.path, `${moduleMetadata.name}.h`);
moduleMetadata.typeMap = includes[libraryName];
modules.set(moduleMetadata.name, moduleMetadata);
});
Expand Down

0 comments on commit 3864fd7

Please sign in to comment.