New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TIMOB-25890] Windows: Support ES6 imports #279
Conversation
Does the following statements work as well (for parity with iOS and Android)? import { MessageDialog, UICommand } from 'Windows.UI.Popups'; |
@hansemannn Currently, var Popups = require('Windows.UI.Popups');
var MessageDialog = Popups.MessageDialog. This doesn't work because Hyperloop Windows |
Ok. Is the PR ready for review then? |
Yes 👍 |
@@ -78,10 +79,24 @@ exports.cliVersion = '>=3.2'; | |||
builder.native_types || (builder.native_types = {}); | |||
builder.native_events || (builder.native_events = {}); | |||
|
|||
// Store relation between local variable name and class name | |||
var native_specifiers = {}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@infosia I am wondering if we can move the Windows hooks to ES6 as well. @sgtcoolguy made huge refactoring progress in #271, but Windows haven't been touched so far. Of course this has no immediate priority!
Asking @sgtcoolguy for review as he did something very similar on #270. |
@hansemannn FYI I'm planning to implement multiple imports like below, which looks similar to android implementation. I would like to do like this because this makes the internal implementation simpler and easier as
|
TIMOB-25890
Enable use of ES6-style imports for Windows.