Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TIMOB-25895] Add Titanium SDK 7.1.1 compatibility #278

Merged
merged 3 commits into from
Mar 31, 2018
Merged

[TIMOB-25895] Add Titanium SDK 7.1.1 compatibility #278

merged 3 commits into from
Mar 31, 2018

Conversation

infosia
Copy link
Contributor

@infosia infosia commented Mar 26, 2018 •
edited

TIMOB-25895

We are expecting to update module apiversion for Windows in upcoming release. This requires modules re-compiled using new DLL.

@infosia infosia changed the title [TIMOB-25895] Add Windows SDK 7.1.1 compatibility [TIMOB-25895] Windows SDK 7.1.1 compatibility + ES6 imports Mar 27, 2018
@infosia infosia changed the title [TIMOB-25895] Windows SDK 7.1.1 compatibility + ES6 imports [TIMOB-25895][TIMOB-25890] Ti SDK 7.1.1 compatibility + ES6 imports Mar 27, 2018
@infosia infosia changed the title [TIMOB-25895][TIMOB-25890] Ti SDK 7.1.1 compatibility + ES6 imports [TIMOB-25895][TIMOB-25890] Ti SDK 7.1.1 compat + ES6 imports Mar 27, 2018
@hansemannn
Copy link
Contributor

@infosia Would you mind moving the ES6-changes to an own PR? We will merge this one and the backport soon and do the 3.1.0 merges after that.

@infosia infosia changed the title [TIMOB-25895][TIMOB-25890] Ti SDK 7.1.1 compat + ES6 imports [TIMOB-25895] Add Titanium SDK 7.1.1 compatibility Mar 27, 2018
@infosia
Copy link
Contributor Author

infosia commented Mar 27, 2018

@hansemannn Sounds good, pushed #279.

@hansemannn
Copy link
Contributor

Hey @infosia! Hyperloop 3.1.0 is ready and could be released anytime soon (definitely after 7.1.1 though). Can you update this PR with the changes from #277 ? It looks like the latest commits have not landed here, yet. Also, if you want, we can do an exclusive Windows release in a Hyperloop 3.0.4 along with SDK 7.1.1 to sync up. I'll prepare the milestones for that.

@infosia
Copy link
Contributor Author

infosia commented Mar 28, 2018

ok, I'll prepare for 3.0.4 Windows exclusive release along with SDK 7.1.1. This PR is aleady ready, part of additional commits that appears in #277 are already merged to master along with #279.

@hansemannn
Copy link
Contributor

@infosia It looks like both master and 3_0_X fail since using 7.1.1?

@hansemannn hansemannn added this to the v3.1.0 milestone Mar 30, 2018
@infosia
Copy link
Contributor Author

infosia commented Mar 30, 2018

Jenkins tends to fail around nuget, which I saw sometimes happening intermittently. I believe it is not caused by this fix. I'll merge 3_0_X fix for now and see what happens then.

@hansemannn
Copy link
Contributor

But without a successfull Jenkins build, we do not get the artifact. Would be good to check it, yeah.

@infosia
Copy link
Contributor Author

infosia commented Mar 31, 2018

ok fixed the build issue. Now ready for review.

@hansemannn hansemannn merged commit 1f4aa1c into tidev:master Mar 31, 2018
@infosia infosia deleted the TIMOB-25895 branch March 31, 2018 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Enhancement Windows
Projects
None yet
Milestone
v3.1.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@infosia @hansemannn