Skip to content

fix(ios): Fixed semver ranges #102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 18, 2019
Merged

fix(ios): Fixed semver ranges #102

merged 5 commits into from
Oct 18, 2019

Conversation

cb1kenobi
Copy link
Contributor

@cb1kenobi cb1kenobi requested a review from ewanharris October 16, 2019 21:29
@cb1kenobi cb1kenobi mentioned this pull request Oct 16, 2019
Merged
@ewanharris
Copy link
Contributor

So trying this with my setup/test cases from #101 (comment)

  • Xcode versions - 11.1 (selected), 10.3, 10.2.1
  • iOS simulator versions - 13.1 (xcode 11), 12.4 (xcode 10.3), 12.2 (xcode 10.3), 9.3 (xcode 10.3)
  1. Building to an iOS 9.3 simulator
    • App build runs just fine, but launching the iOS simulator errors with [ERROR] Selected iOS Simulator 406A070D-3D79-4423-9FCE-4F0862216902 does not support Xcode 11.1:11A1027z
  2. Build to a 12.2 simulator, then rebuild to a 13.1 simulator
    • Launching the iOS 12.2 simulator errors out with [ERROR] Selected iOS Simulator 95A4B577-80A4-42DC-8802-41DC7F01C4A8 does not support Xcode 11.1:11A1027
  3. Build to a 13.1 simulator, then rebuild to a 12.4 simulator
    • 13.1 sim launches fine, launching the iOS 12.4 simulator errors out with [ERROR] Selected iOS Simulator A5365974-1598-4E87-A0FF-8EEDE17C5899 does not support Xcode 11.1:11A1027

@cb1kenobi what's the expectations of this PR?

@cb1kenobi
Copy link
Contributor Author

@ewanharris I naively use the selectedXcode version to select the simctl, when it doesn't matter. I'll refactor.

@cb1kenobi cb1kenobi changed the title fix(ios): Fixed semver ranges and cache simctl/simulator per Xcode. fix(ios): Fixed semver ranges Oct 17, 2019
@cb1kenobi cb1kenobi mentioned this pull request Oct 17, 2019
Merged
ewanharris
ewanharris approved these changes Oct 18, 2019
View reviewed changes
Copy link
Contributor

@ewanharris ewanharris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR/FR pass

  1. Building to an iOS 9.3 simulator
  2. Build to a 12.2 simulator, then rebuild to a 13.1 simulator
  3. Build to a 13.1 simulator, then rebuild to a 12.4 simulator

@ewanharris ewanharris merged commit 68999e6 into 1_7_X Oct 18, 2019
@ewanharris ewanharris deleted the TIMOB-27463_1_7_X branch October 18, 2019 11:20
@lokeshchdhry lokeshchdhry mentioned this pull request Oct 19, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ewanharris ewanharris ewanharris approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cb1kenobi @ewanharris