Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix xcodebuild dest, bump min iOS target to 9, disable ONLY_ACTIVE_ARCH for 32-bit sims #11281

Merged
merged 11 commits into from
Oct 19, 2019
Merged

Fix xcodebuild dest, bump min iOS target to 9, disable ONLY_ACTIVE_ARCH for 32-bit sims #11281

merged 11 commits into from
Oct 19, 2019

Conversation

cb1kenobi
Copy link
Contributor

@cb1kenobi cb1kenobi commented Oct 15, 2019 •
edited

@build build added this to the 8.3.0 milestone Oct 15, 2019
@build
Copy link
Contributor

build commented Oct 15, 2019 •
edited

Messages
📖

💾 Here's the generated SDK zipfile.
📖

✅ All tests are passing
Nice one! All 4403 tests are passing.
(There are 479 skipped tests not included in that total)
📖 ✊ The commits in this PR match our conventions! Feel free to Rebase and Merge this PR when ready.

Dependencies with modified semantic versioning:

  • ioslib - from ^1.7.14 to ^1.7.15

Generated by 🚫 dangerJS against 270d3e0

ewanharris
ewanharris approved these changes Oct 15, 2019
View reviewed changes
Copy link
Collaborator

@ewanharris ewanharris left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR looks good

@cb1kenobi do you think this will fix any issues mentioned in tidev/ioslib/pull/101? I think keeping this "just pick a simulator" we're doing in this block of code is causing issues with xcodebuild

@cb1kenobi cb1kenobi mentioned this pull request Oct 15, 2019
Merged
@ssekhri
Copy link

ssekhri commented Oct 15, 2019

FR Passed.
Verified On:
Mac OS: 10.14.5
SDK: 8.3.0.v20191015071817
Appc CLI: 7.1.1
JDK: 1.8.0_162
Node: 10.5.0
Studio: 5.1.4.201909061933
Xcode: 11.0, 10.3
iOS simulator v13.0, 12.4, 12.2

@ewanharris
Copy link
Collaborator

@ssekhri @cb1kenobi do we want to push the ioslib@v1.7.15 update into this PR also so that we can fix the issues we're seeing on some Jenkins nodes?

@cb1kenobi
Copy link
Contributor Author

@ewanharris ioslib@1.7.15 has not been published yet. We can hold off on this PR until it is published... hopefully later today.

@cb1kenobi
Merge branch 'master' into TIMOB-27338
a615d24
@cb1kenobi
fix(ios): xcode 11 fixes
9f0c062 
* Bumped min iOS target from 8 to 9.
* For sim builds, only build active arch for 64-bit sim devices.
* Only create legacy launch image asset catalog when using Xcode 10 and older.
@cb1kenobi
Merge branch 'TIMOB-27338' of github.com:cb1kenobi/titanium_mobile in…
0b89c46 
…to TIMOB-27338
@cb1kenobi
Merge branch 'master' into TIMOB-27338
0c5e850
@cb1kenobi
fix(ios): reenabled launch images
e07034d
@cb1kenobi
Merge branch 'TIMOB-27338' of github.com:cb1kenobi/titanium_mobile in…
a404076 
…to TIMOB-27338
@lokeshchdhry
Copy link
Contributor

@cb1kenobi , Is this PR all goods to get tested ?

@cb1kenobi
Copy link
Contributor Author

@lokeshchdhry No. Ewan found an issue he sent me in DM. Investigating now.

@cb1kenobi
Copy link
Contributor Author

Note: this PR requires this ioslib PR: tidev/ioslib#102.

@cb1kenobi cb1kenobi changed the title fix(ios): break outer dest loop if dest found Fix xcodebuild dest, bump min iOS target to 9, disable ONLY_ACTIVE_ARCH for 32-bit sims Oct 17, 2019
@ewanharris
Copy link
Collaborator

ioslib PR was good so I published it and updated it here and in #11282

@ewanharris
Copy link
Collaborator

@lokeshchdhry this is good for testing now. You can find info about the testing I've done so far here tidev/ioslib#102 (comment)

@lokeshchdhry
Copy link
Contributor

lokeshchdhry commented Oct 19, 2019 •
edited

FR Passed.

Followed tests here tidev/ioslib#102 (comment)

SDK: 8.3.0 local build

@lokeshchdhry lokeshchdhry merged commit 74d78fb into tidev:master Oct 19, 2019
@cb1kenobi cb1kenobi deleted the TIMOB-27338 branch October 21, 2019 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ewanharris ewanharris ewanharris approved these changes

Assignees
No one assigned
Labels
in-qe-testing 🕵
Projects
None yet
Milestone
8.3.0
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@cb1kenobi @build @ssekhri @ewanharris @lokeshchdhry @ssjsamir