Fix inconsistensies in module detection #171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manifest apiversions and sdk provided apiversions are passed through as strings, apiversions from npm installed modules are provided as integers, by parsing everything to an integer before comparison we ensure we're comparing the same type always Fixes TIMOB-27204
If we cant find iOS moduleAPIVersion in the provided object fallback to using iphone as that is the current value in the SDK, by only falling back if we dont find it we provide ourselves an easier path to using ios as the standard in future Fixes TIMOB-27203
ewanharris
force-pushed
the
fix_inconsistensies
branch
from
7ed6b8b
to
24fd149
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
c670fc5 TIMOB-27203 - iOS: no apiversion validation performed on application build
2974e52 TIMOB-27204 - CLI: apiversion validation always fails for native modules installed via npm
Commits should be structured so this can be "Rebase and merged"