Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix inconsistensies in module detection #171

Merged
merged 3 commits into from
Jul 2, 2019
Merged

Fix inconsistensies in module detection #171

merged 3 commits into from
Jul 2, 2019

Commits on Jul 2, 2019

  1. fix(module): parse apiversions to integer before comparing 

    manifest apiversions and sdk provided apiversions are passed through as strings, apiversions from npm installed modules are provided as integers, by parsing everything to an integer before comparison we ensure we're comparing the same type always

Fixes TIMOB-27204
    @ewanharris
    ewanharris committed Jul 2, 2019
    Configuration menu
    Copy the full SHA
    87403f6 View commit details
    Browse the repository at this point in the history

  2. fix(module): if platform is ios fallback to iphone in moduleAPIVersion 

    If we cant find iOS moduleAPIVersion in the provided object fallback to using iphone as that is the current value in the SDK, by only falling back if we dont find it we provide ourselves an easier path to using ios as the standard in future

Fixes TIMOB-27203
    @ewanharris
    ewanharris committed Jul 2, 2019
    Configuration menu
    Copy the full SHA
    f9aa9ec View commit details
    Browse the repository at this point in the history

  3. chore(release): bump to 0.3.3

    @ewanharris
    ewanharris committed Jul 2, 2019
    Configuration menu
    Copy the full SHA
    24fd149 View commit details
    Browse the repository at this point in the history