Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TIMOB-26919] Android: Support d8 dexer. #80

Closed
wants to merge 2 commits into from
Closed

[TIMOB-26919] Android: Support d8 dexer. #80

wants to merge 2 commits into from

Conversation

drauggres
Copy link

This PR don't really provide d8 support, but exports two additional properties available inside AndroidBuilder methods:

  • this.androidInfo.sdk.d8 - path to d8 jar
  • this.tiapp.android.enableDesugar - value of property in tiapp.xml:
<ti:app xmlns:ti="http://ti.appcelerator.org">
  ...
  <android>
    <manifest>...</manifest>
    <enableDesugar>true</enableDesugar>
  </android>
  ...
</ti>

P.S. Origin of enableDesugar property name.

@build
Copy link

build commented Mar 26, 2019

Warnings
⚠️

lib/android.js#L62 - lib/android.js line 62 – Found non-literal argument in require (security/detect-non-literal-require)

⚠️

lib/android.js#L156 - lib/android.js line 156 – Empty block statement. (no-empty)

⚠️

lib/android.js#L216 - lib/android.js line 216 – Empty block statement. (no-empty)

⚠️

lib/android.js#L241 - lib/android.js line 241 – 'stderr' is defined but never used. (no-unused-vars)

⚠️

lib/android.js#L245 - lib/android.js line 245 – 'stderr' is defined but never used. (no-unused-vars)

⚠️

lib/android.js#L266 - lib/android.js line 266 – 'err' is defined but never used. (no-unused-vars)

⚠️

lib/android.js#L298 - lib/android.js line 298 – 'stderr' is defined but never used. (no-unused-vars)

⚠️

lib/android.js#L747 - lib/android.js line 747 – '+=' should be placed at the beginning of the line. (operator-linebreak)

⚠️

lib/android.js#L825 - lib/android.js line 825 – Found non-literal argument to RegExp Constructor (security/detect-non-literal-regexp)

⚠️

lib/android.js#L826 - lib/android.js line 826 – Found non-literal argument to RegExp Constructor (security/detect-non-literal-regexp)

⚠️

lib/android.js#L1088 - lib/android.js line 1088 – 'systemImages' is defined but never used. (no-unused-vars)

Messages
📖

✅ All tests are passing
Nice one! All 22 tests are passing.

Generated by 🚫 dangerJS against 2e84234

@danimarin
Copy link

This D8 option is really important, we are having the same issues with the last JWPlayer (which uses Exoplayer). And more libraries are starting to use some Java 8 features.

The patch is working great for us, thanks for the workaround because the new JWPlayer libraries update were really blocking our apps.

@garymathews
Copy link
Contributor

Closing, as we will be using D8 through moving to Gradle builds.

@garymathews garymathews closed this Sep 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants