fix(ios): trying to fix crash issue (#12760)

Fixes TIMOB-28296
tidev · Apr 29, 2021 · 0468283 · 0468283
1 parent 6b3a9ec
commit 0468283
Showing 1 changed file with 8 additions and 3 deletions.
diff --git a/iphone/Classes/TiUIPickerProxy.m b/iphone/Classes/TiUIPickerProxy.m
@@ -36,6 +36,12 @@ - (NSString *)apiName
   return @"Ti.UI.Picker";
 }
 
+- (void)dealloc
+{
+  RELEASE_TO_NIL(pickerKeySequence);
+  [super dealloc];
+}
+
 - (void)_destroy
 {
   RELEASE_TO_NIL(selectOnLoad);
@@ -104,8 +110,7 @@ - (TiUIPickerColumnProxy *)columnAt:(NSInteger)index
   TiUIPickerColumnProxy *column = [[TiUIPickerColumnProxy alloc] _initWithPageContext:[self executionContext]];
   column.column = index;
   [columns addObject:column];
-  [column release];
-  return column;
+  return [column autorelease];
 }
 
 #pragma mark support methods for add:
@@ -254,9 +259,9 @@ - (void)add:(id)args
         TiUIPickerRowProxy *row = [[TiUIPickerRowProxy alloc] _initWithPageContext:[self executionContext] args:[NSArray arrayWithObject:rowdata]];
         TiUIPickerColumnProxy *column = [self columnAt:0];
         NSNumber *rowIndex = [column addRow:row];
+        NSDictionary *params = [NSDictionary dictionaryWithObjectsAndKeys:row, @"row", column, @"column", rowIndex, @"rowIndex", nil];
         [row release];
 
-        NSDictionary *params = [NSDictionary dictionaryWithObjectsAndKeys:row, @"row", column, @"column", rowIndex, @"rowIndex", nil];
         [self addRowOfDicts:params];
       }
     } else {