[TIMOB-26033]: iOS Ti.Media.VideoPlayer shows an error on Window Close on SDK 7.1.1.GA #10071
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e on SDK 7.1.1.GA
Generated by 🚫 dangerJS |
hansemannn
reviewed
May 22, 2018
| @@ -117,8 +117,10 @@ - (void)addNotificationObserver | |||
|
|
|||
| - (void)removeNotificationObserver | |||
| { | |||
| if ([self observationInfo]) { | |||
| [self removeObserver:self forKeyPath:@"url"]; | |||
There was a problem hiding this comment.
Does this only apply for the url KVO or possibly others as well (once triggered)?
There was a problem hiding this comment.
For others also we can apply. But 'movie' object already becomes nil. So no need to apply this check for others.
hansemannn
approved these changes
May 22, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.appcelerator.org/browse/TIMOB-26033