Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TIMOB-26033]: iOS Ti.Media.VideoPlayer shows an error on Window Close on SDK 7.1.1.GA #10071

Merged
merged 3 commits into from
May 22, 2018
Merged

[TIMOB-26033]: iOS Ti.Media.VideoPlayer shows an error on Window Close on SDK 7.1.1.GA #10071

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3bce30b
[TIMOB-26033]: iOS Ti.Media.VideoPlayer shows an error on Window Clos…
vijaysingh-axway May 22, 2018
f1a8736
[TIMOB-26033] : Unit test added
vijaysingh-axway May 22, 2018
16a103f
[TIMOB-26033] : Indentation fixed
vijaysingh-axway May 22, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 3 additions & 1 deletion iphone/Classes/TiMediaVideoPlayerProxy.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,8 +117,10 @@ - (void)addNotificationObserver

- (void)removeNotificationObserver
{
if ([self observationInfo]) {
[self removeObserver:self forKeyPath:@"url"];
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this only apply for the url KVO or possibly others as well (once triggered)?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For others also we can apply. But 'movie' object already becomes nil. So no need to apply this check for others.

}
[movie removeObserver:self forKeyPath:@"player.currentItem.duration"];
[self removeObserver:self forKeyPath:@"url"];
[movie removeObserver:self forKeyPath:@"player.status"];
[movie removeObserver:self forKeyPath:@"videoBounds"];

Expand Down