[TIMOB-26094] iOS 12: Add new Ti.UI.TextField API's #10088
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@hansemannn TiApp.m fails to compile on Jenkins here as well (like it does on #10098). The machine it built on does have Xcode 9 installed... |
|
Also this PR looks like it's two separate tickets/issues that aren't particularly related... |
|
@sgtcoolguy I need to rebase with the latest changes, thanks for merging! The reason these two are together is that all Xcode 10 additions to the SDK require the IS_XCODE_10 macro, which I've put there to unblock development. I will split it up now and we need to rebase once the macro is merged, so Jenkins passes. EDIT: Moved to #10105 |
Generated by 🚫 dangerJS |
sgtcoolguy
changed the title
hansemannn
changed the title
hansemannn
commented
Jul 11, 2018
| @@ -11,7 +11,7 @@ | |||
| var should = require('./utilities/assertions'); | |||
|
|
|||
| describe('Ti.UI.TextField', function () { | |||
| it('.passwordRules', function () { | |||
| it.ios('.passwordRules', function () { | |||
Generated by 🚫 dangerJS |
sgtcoolguy
pushed a commit
that referenced
this pull request
Aug 27, 2018
* [TIMOB-26090] Add Xcode 10 macro, fix compiler warning * [TIMOB-26094] Expose new autofill constants * [TIMOB-26094] Expose password rules API * Update fix-versions * Remove Xcode 10 related dev-env changes * Update Titanium_Prefix.pch * Restructure code * Update TiUITextWidget.m * Enforce xcode-10 to run unit tests on Jenkins. Add unit tests for new APIs/constants * Mark new tests as ios-specific
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: https://jira.appcelerator.org/browse/TIMOB-26094