[TIMOB-26111] iOS: Fix all static analyzer warnings and possible leaks #10098
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@hansemannn Looks like TiApp.m fails to compile on Jenkins here |
|
@sgtcoolguy It looks like Xcode 9 does not expose the `` protocol public, so I'd like to wrap it for Xcode 9 and 10. But that requires https://github.com/appcelerator/titanium_mobile/pull/10088/files#diff-d564eaef8d6d4f17f70247e5ec99cde7R20 to be merged first, so I can use conditional compiling. Until then, I restored that part, since it's just a warning. |
Generated by 🚫 dangerJS |
hansemannn
added a commit
to hansemannn/titanium_mobile
that referenced
this pull request
Jun 25, 2018
tidev#10098) * Fix all warnings and leaks * Format source * Restore old NSUserActivity protocol until Xcode 10 PR is merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: https://jira.appcelerator.org/browse/TIMOB-26111