[TIMOB-25942] : iOS 11: Screen orientation not working in navigation window #10104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 dangerJS |
hansemannn
requested changes
Jun 13, 2018
| fromOrientation:[[UIApplication sharedApplication] statusBarOrientation]]; | ||
| if ([TiUtils isIOS11OrGreater]) { | ||
| forcingStatusBarOrientation = YES; | ||
| [[UIApplication sharedApplication] setStatusBarOrientation:target animated:NO]; |
There was a problem hiding this comment.
This method is deprecated in iOS 9+, we should use a wrapper to use the iOS 10+ API for newer devices.
There was a problem hiding this comment.
@vijaysingh-axway Can you add the [TiUtils isLowerThan:@"12.0"] (or how the method was named) check to only add this workaround for iOS 11?
|
Apple has deprecated setStatusBarOrientation method in iOS9+ and haven't given any direct method to set status bar orientation. Need to check some different way to do this. |
Generated by 🚫 dangerJS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.appcelerator.org/browse/TIMOB-25942