-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TIMOB-25942] : iOS 11: Screen orientation not working in navigation window #10104
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
767fcc0
[TIMOB-25942] : iOS 11: Screen orientation not working in navigation …
vijaysingh-axway 8b80c44
Merge branch 'master' into TIMOB-25942
vijaysingh-axway 5c19b85
[TIMOB-25942] : Condition updated for ios 11 only
vijaysingh-axway 1d0613d
Merge branch 'master' into TIMOB-25942
keerthi1032 File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,63 @@ | ||
/* | ||
* Appcelerator Titanium Mobile | ||
* Copyright (c) 2011-Present by Appcelerator, Inc. All Rights Reserved. | ||
* Licensed under the terms of the Apache Public License | ||
* Please see the LICENSE included with this distribution for details. | ||
*/ | ||
/* eslint-env mocha */ | ||
/* global Ti */ | ||
/* eslint no-unused-expressions: "off" */ | ||
'use strict'; | ||
var should = require('./utilities/assertions'); | ||
|
||
describe('Titanium.UI.Window', function () { | ||
var win, | ||
rootWindow; | ||
|
||
this.timeout(5000); | ||
|
||
// Create and open a root window for the rest of the below child window tests to use as a parent. | ||
// We're not going to close this window until the end of this test suite. | ||
// Note: Android needs this so that closing the last window won't back us out of the app. | ||
before(function (finish) { | ||
rootWindow = Ti.UI.createWindow(); | ||
rootWindow.addEventListener('open', function () { | ||
finish(); | ||
}); | ||
rootWindow.open(); | ||
}); | ||
|
||
after(function (finish) { | ||
rootWindow.addEventListener('close', function () { | ||
finish(); | ||
}); | ||
rootWindow.close(); | ||
}); | ||
|
||
afterEach(function () { | ||
if (win) { | ||
win.close(); | ||
} | ||
win = null; | ||
}); | ||
|
||
it.ios('.statusBarStyle', function (finish) { | ||
win = Ti.UI.createWindow({ | ||
title: 'This is status bar style test', | ||
statusBarStyle: Ti.UI.iOS.StatusBar.LIGHT_CONTENT | ||
}); | ||
|
||
win.addEventListener('open', function () { | ||
try { | ||
should(win.statusBarStyle).be.a.Number; | ||
should(win.statusBarStyle).eql(Ti.UI.iOS.StatusBar.LIGHT_CONTENT); | ||
win.setStatusBarStyle(Ti.UI.iOS.StatusBar.GRAY); | ||
should(win.statusBarStyle).eql(Ti.UI.iOS.StatusBar.GRAY); | ||
finish(); | ||
} catch (err) { | ||
finish(err); | ||
} | ||
}); | ||
win.open(); | ||
}); | ||
}); |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This method is deprecated in iOS 9+, we should use a wrapper to use the iOS 10+ API for newer devices.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vijaysingh-axway Can you add the
[TiUtils isLowerThan:@"12.0"]
(or how the method was named) check to only add this workaround for iOS 11?