New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TIMOB-26090] iOS: Add Xcode 12 dev-env #10105
Conversation
@@ -18,8 +18,8 @@ | |||
"minIosVersion": "8.0", | |||
"minWatchosVersion": "1.0", | |||
"vendorDependencies": { | |||
"xcode": ">=6.0 <=9.x", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sgtcoolguy Not bumping Xcode here, but we should require Xcode 8+ in Ti SDK 8.0.0, since we actually do via code already.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These ranges are used by ti info
to detect issues. I'd be fine with bumping this to >=8.0 <=10.x
.
Tests:
Generated by 🚫 dangerJS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to merge once that Xcode min is bumped to 8.0 in the package.json as per Chris Barber's comment.
* [TIMOB-26090] Add Xcode 12 dev-env
JIRA: https://jira.appcelerator.org/browse/TIMOB-26090