Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TIMOB-26090] iOS: Add Xcode 12 dev-env #10105

Merged
merged 2 commits into from
Jun 13, 2018
Merged

[TIMOB-26090] iOS: Add Xcode 12 dev-env #10105

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0cc848a
[TIMOB-26090] Add Xcode 12 dev-env
hansemannn Jun 13, 2018
d790800
Update package.json
hansemannn Jun 13, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 5 additions & 0 deletions iphone/iphone/Titanium_Prefix.pch
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,3 +17,8 @@
#define IS_XCODE_9 false
#endif

#if __IPHONE_OS_VERSION_MAX_ALLOWED >= 120000
#define IS_XCODE_10 true
#else
#define IS_XCODE_10 false
#endif
4 changes: 2 additions & 2 deletions iphone/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,8 @@
"minIosVersion": "8.0",
"minWatchosVersion": "1.0",
"vendorDependencies": {
"xcode": ">=6.0 <=9.x",
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sgtcoolguy Not bumping Xcode here, but we should require Xcode 8+ in Ti SDK 8.0.0, since we actually do via code already.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These ranges are used by ti info to detect issues. I'd be fine with bumping this to >=8.0 <=10.x.

"ios sdk": ">=8.0 <=11.x",
"xcode": ">=8.0 <=10.x",
"ios sdk": ">=8.0 <=12.x",
"node": ">=4.0 <=8.x"
},
"repository": {
Expand Down