[TIMOB-24589] TiAPI: Remove Ti.Yahoo #10125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 dangerJS |
sgtcoolguy
reviewed
Jun 20, 2018
| @@ -14,6 +14,10 @@ methods: | |||
| - name: callback | |||
| summary: the function to execute when the query completes. | |||
| type: Callback<YQLResponse> | |||
| deprecated: | |||
| since: "8.0.0" | |||
There was a problem hiding this comment.
didn't we deprecate this before?
There was a problem hiding this comment.
I think we planned to in 7 but never came to it
sgtcoolguy
approved these changes
Jun 20, 2018
tidev#10205) * [TIMOB-26209] Only error out if selected xcode EULA has not been accepted * Update package-lock.json
sgtcoolguy
suggested changes
Jul 26, 2018
| @@ -143,8 +143,6 @@ protected static String getImTextType(int type) | |||
| key = "custom"; | |||
| } else if (type == ContactsContract.CommonDataKinds.Im.PROTOCOL_MSN) { | |||
| key = "msn"; | |||
| } else if (type == ContactsContract.CommonDataKinds.Im.PROTOCOL_YAHOO) { | |||
There was a problem hiding this comment.
Should this be removed? Does Yahoo still have IM? I don't think it's related to our Ti.Yahoo API.
| @@ -286,8 +286,6 @@ protected int processIMProtocol(String serviceName) | |||
| return Im.PROTOCOL_QQ; | |||
| } else if (serviceName.equals("Skype")) { | |||
| return Im.PROTOCOL_SKYPE; | |||
| } else if (serviceName.equals("Yahoo")) { | |||
There was a problem hiding this comment.
Should this be removed? Does Yahoo still have IM? I don't think it's related to our Ti.Yahoo API.
sgtcoolguy
approved these changes
Jul 30, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: https://jira.appcelerator.org/browse/TIMOB-24589