-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TIMOB-24589] TiAPI: Remove Ti.Yahoo #10125
Conversation
Generated by 🚫 dangerJS |
@@ -14,6 +14,10 @@ methods: | |||
- name: callback | |||
summary: the function to execute when the query completes. | |||
type: Callback<YQLResponse> | |||
deprecated: | |||
since: "8.0.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
didn't we deprecate this before?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we planned to in 7 but never came to it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should have been killed off a very long time ago...
tidev#10205) * [TIMOB-26209] Only error out if selected xcode EULA has not been accepted * Update package-lock.json
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you removed a couple yahoo related things from the contacts API that wren't tied to our Ti.Yahoo API in any way and should have been retained.
Also, This should probably be targeting next branch now.
@@ -143,8 +143,6 @@ protected static String getImTextType(int type) | |||
key = "custom"; | |||
} else if (type == ContactsContract.CommonDataKinds.Im.PROTOCOL_MSN) { | |||
key = "msn"; | |||
} else if (type == ContactsContract.CommonDataKinds.Im.PROTOCOL_YAHOO) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be removed? Does Yahoo still have IM? I don't think it's related to our Ti.Yahoo API.
@@ -286,8 +286,6 @@ protected int processIMProtocol(String serviceName) | |||
return Im.PROTOCOL_QQ; | |||
} else if (serviceName.equals("Skype")) { | |||
return Im.PROTOCOL_SKYPE; | |||
} else if (serviceName.equals("Yahoo")) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be removed? Does Yahoo still have IM? I don't think it's related to our Ti.Yahoo API.
JIRA: https://jira.appcelerator.org/browse/TIMOB-24589