Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(android): prevent duplicate analytics initialization #10518

Merged
merged 2 commits into from
Dec 11, 2018
Merged

fix(android): prevent duplicate analytics initialization #10518

merged 2 commits into from
Dec 11, 2018

Conversation

garymathews
Copy link
Contributor

  • Prevent analytics from initializing twice
TEST CASE
  • Disable analytics
  • Should not see [INFO] TiApplication: (main) [369,369] Analytics have been disabled on startup

JIRA Ticket

@garymathews garymathews added this to the 8.0.0 milestone Dec 7, 2018
@build build requested a review from a team December 7, 2018 21:55
@build
Copy link
Contributor

build commented Dec 7, 2018 •
edited
Loading

Messages
📖 👍 Hey!, You deleted more code than you added. That's awesome!
📖

💾 Here's the generated SDK zipfile.

Generated by 🚫 dangerJS

jquick-axway
jquick-axway approved these changes Dec 10, 2018
View reviewed changes
Copy link
Contributor

@jquick-axway jquick-axway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: Pass

@jquick-axway
Copy link
Contributor

Right. We already call the postAppInfo() method in the "App.java" template.
https://github.com/appcelerator/titanium_mobile/blob/master/android/templates/build/App.java

@garymathews garymathews mentioned this pull request Dec 11, 2018
Merged
@lokeshchdhry
Copy link
Contributor

FR Passed.

Studio Ver: 5.1.2.201810301430
SDK Ver: 8.0.0 local build
OS Ver: 10.14
Xcode Ver: Xcode 10.1
Appc NPM: 4.2.13
Appc CLI: 7.0.8
Daemon Ver: 1.1.3
Ti CLI Ver: 5.1.1
Alloy Ver: 1.13.4
Node Ver: 8.9.1
NPM Ver: 5.5.1
Java Ver: 10.0.2
Devices: ⇨ google Nexus 5 (Android 6.0.1)
⇨ google Pixel (Android 9)

@lokeshchdhry lokeshchdhry merged commit 5dc5afc into tidev:master Dec 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jquick-axway jquick-axway jquick-axway approved these changes

Assignees
No one assigned
Labels
android bug in-qe-testing 🕵 no tests
Projects
None yet
Milestone
8.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@garymathews @build @jquick-axway @lokeshchdhry