feat(ios) : Added functionality to show search bar in navigation bar for TiUIListView and TiUITableView

[vijaysingh-axway]

https://jira.appcelerator.org/browse/TIMOB-26509

[build]

	Messages
📖	💾 Here's the generated SDK zipfile.
📖	✅ All tests are passing Nice one! All 2995 tests are passing.

Generated by 🚫 dangerJS against 1083086

[hansemannn]

I think the iOS 11 guard is required here.

[vijaysingh-axway]

It's already taken care while assigning value to variable 'isSearchBarInNavigation'.
isSearchBarInNavigation = [TiUtils boolValue:[(TiViewProxy *)self.proxy valueForUndefinedKey:@"showSearchBarInNavigation"] def:NO] && [TiUtils isIOSVersionOrGreater:@"11.0"];

[janvennemann]

@vijaysingh-axway Since we still support older Xcode and SDK versions that don't have the searchController property we need the iOS 11 safeguard anyway. Probably something similar to #10729

[vijaysingh-axway]

@janvennemann Wrapped under macro IS_XCODE_9.

[hansemannn]

osver: {ios: {min: "11.0"}}

[vijaysingh-axway]

Updated. Thanks!

[hansemannn]

Do the docs allow to use Ti.UI instead of Titanium.UI these days?

[hansemannn]

I assume this does not work without ListView / TableView right now? Not too critical, but maybe required in the future.

[hansemannn]

Really quick and minor comment: Usually, the UINavigationBar is referenced as the navBar in Titanium, e.g. navBarHidde and hideNavBar / showNavBar. For the sake of parity, this could become showSearchBarInNavBar if you agree.

[vijaysingh-axway]

Agree. Updated PR.

[janvennemann]

Added a minor note about required backwards compatibility with older Xcode/iOS SDK versions.

[janvennemann]

CR passed!

[ssjsamir]

FR Passed. Able to see search bar in navigation bar for TiUIListView and TiUITableView. Tested with the following test cases:

var rows = [];

for (var i = 0; i < 20; i++) {
var title = i ? 'Row '+ i : 'Close Window'
rows.push({ properties: { title:title  , backgroundColor: 'red', searchableText:title}});
}
 
var win = Ti.UI.createWindow({
title: 'TEST',
backgroundColor: 'white',
});
 
var nav = Ti.UI.iOS.createNavigationWindow({
window: win,
});
 
var sb = Ti.UI.createSearchBar();
 
var ls = Ti.UI.createListSection({
items: rows
});
 
var lv = Ti.UI.createListView({
dimBackgroundForSearch: true,
sections: [ls],
searchView: sb,
showSearchBarInNavBar: true
});
 
sb.setHintText("test");
sb.addEventListener('change', function(e){
Ti.API.info(e.value);
});
sb.addEventListener('return', function(e){
sb.blur();
});
win.add(lv);
nav.open();

TiUIListView:

var rows = [];

for (var i = 0; i < 20; i++) {
var title = i ? 'Row '+ i : 'Close Window'
rows.push({ properties: { title:title  , backgroundColor: 'red', searchableText:title}});
}
 
var win = Ti.UI.createWindow({
title: 'TEST',
backgroundColor: 'white',
hidesSearchBarWhenScrolling: false
});
 
var nav = Ti.UI.createNavigationWindow({
window: win,
});
 
var sb = Ti.UI.createSearchBar({
hintTextColor: 'white'
});
 
var ls = Ti.UI.createListSection({
items: rows
});
 
var lv = Ti.UI.createListView({
dimBackgroundForSearch: true,
sections: [ls],
searchView: sb,
showSearchBarInNavBar: true
});
 
sb.setHintText("test");
sb.addEventListener('change', function(e){
Ti.API.info(e.value);
});
 
sb.addEventListener('return', function(e){
sb.blur();
});
 
win.add(lv);
nav.open();

TiUITableView:

var rows = [];

for (var i = 0; i < 10; i++) {
var title = i ? 'Row '+ i : 'Close Window';
rows.push({ title: title});
}
 
var win = Ti.UI.createWindow({
backgroundColor: 'red',
hidesSearchBarWhenScrolling: true
});
 
var sb = Ti.UI.createSearchBar({
hintTextColor: 'blue'
});
var lv = Ti.UI.createTableView({
data: rows,
search: sb,
showSearchBarInNavBar: true,
});
 
sb.setHintText("test");
sb.addEventListener('change', function(e){
Ti.API.info(e.value);
});
 
sb.addEventListener('return', function(e){
sb.blur();
});
 
sb.addEventListener('cancel', function(e){
});
lv.addEventListener('click', function(e) {
})
 
win.add(lv);
var nav = Ti.UI.iOS.createNavigationWindow({
window: win,
});
nav.open();

Test Environment

iPhone 6S plus (12.1 Sim)
APPC CLI: 7.0.10-17
Operating System Name: Mac OS Mojave
Operating System Version: 10.14.2
Node.js Version: 8.9.1
Xcode 10.1

[hansemannn]

Great to see this merged, thanks everyone!