fix(ios): add missing runtime checks #10729
Conversation
iphone/Classes/MediaModule.m
Outdated
| MPMediaItemPropertyLastPlayedDate, @"lastPlayedDate", | ||
| MPMediaItemPropertyUserGrouping, @"userGrouping", | ||
| MPMediaItemPropertyBookmarkTime, @"bookmarkTime", | ||
| #ifdef __IPHONE_10_0 |
There was a problem hiding this comment.
These have been used to ensure Xcode compatibility (in the above case to support Xcode 7 although the API would require Xcode 8). Is there a concept to support this in the future? I could think of class extensions that are injected outside TitaniumKit.
There was a problem hiding this comment.
Ahhh thanks for the explanation, that makes sense. So i think we still need these but with an additional runtime check like in the WebView below to prevent the runtime crash on devices that are actually below the checked iOS version.
|
@vijaysingh-axway can you give this another look? |
janvennemann
changed the title
|
@janvennemann @hansemannn As per previous history in titanium sdk, I can say that we guard current Xcode sdk and current Xcode sdk - 1. e.g in titanium SDK 8.0.0 we guard against Xcode 10 and Xcode 9. |
|
Well, technically it is possible to use old iOS SDKs with newer Xcode versions. So i think the check against the iOS SDK is more sophisticated and generally more expressive. It makes clear what the check is meant to do: check the iOS SDK version. Although Xcode versions are (usually) tied to a specific iOS SDK checking for the Xcode version seems confusing to me. If you don't know the SDK version shipped with Xcode you need to look that up. |
There was a problem hiding this comment.
FR Passed Titanium.Media.openMusicLibrary no longer returns empty items on iOS 9.3.5 and no longer crashes the application. Tested using the test case from: https://jira.appcelerator.org/browse/TIMOB-26829
Test Environment
iphone 5s (9.3.5)
APPC CLI: 7.0.10
Operating System Name: Mac OS Mojave
Operating System Version: 10.14.2
Node.js Version: 8.9.1
Xcode 10.1
|
JIRA: https://jira.appcelerator.org/browse/TIMOB-26829
The
__IPHONE_XX_Xmacros are evaluated at compile time which could lead to crashes on devices running a lower version than what the macros checked against. To prevent that i added runtime checks for the required version in the media module which was affected by the crash.