fix(android): Fixes TabLayout gravity when changing orientation #10687
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Takes care of switching a TabLayout's TabGravity depending on current orientation.
|
jquick-axway
reviewed
Feb 8, 2019
| } else if (newConfig.orientation == Configuration.ORIENTATION_LANDSCAPE) { | ||
| mTabLayout.setTabGravity(TabLayout.GRAVITY_CENTER); | ||
| } | ||
| } |
There was a problem hiding this comment.
Minor nit-pick. You can get rid of the mTabLayout. part since you're overriding the TabLayout class' onConfigurationChanged() method. The rest is fine. Nice and simple solution. 👍
|
FR Passed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: https://jira.appcelerator.org/browse/TIMOB-26698
Description:
Takes care of switching a TabLayout's TabGravity depending on current orientation. Due to Titanium not recreating activities on orientation changes the style defined for the TabLayout in Design support library will not be applied, because the TabLayout won't be redrawn. This PR makes the change on configurationChanged event and effectively changes the component according to the new style. The change from the default style is actually only the tabGravity property.
Edit: No unit test for this one - it is a visual change.
Test case:
There is a good code sample in the JIRA ticket.