Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(android): Fixes TabLayout gravity when changing orientation #10687

Merged
merged 6 commits into from
Mar 25, 2019
Merged

fix(android): Fixes TabLayout gravity when changing orientation #10687

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
2033164
fix(android): Fixes TabLayout gravity when changing orientation
Feb 8, 2019
c5bdeec
refactor(android): Remove unnecessary reference of tabLayout.
Feb 12, 2019
788e817
Merge branch 'master' into TIMOB-26698
Feb 26, 2019
24a296b
Merge branch 'master' into TIMOB-26698
longton95 Feb 27, 2019
fd30067
Merge branch 'master' into TIMOB-26698
longton95 Feb 28, 2019
5b964d0
Merge branch 'master' into TIMOB-26698
sgtcoolguy Mar 25, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
13 changes: 12 additions & 1 deletion ...oid/modules/ui/src/java/ti/modules/titanium/ui/widget/tabgroup/TiUITabLayoutTabGroup.java
View file
Open in desktop
Expand Up @@ -6,11 +6,11 @@
*/
package ti.modules.titanium.ui.widget.tabgroup;

import android.content.res.Configuration;
import android.graphics.drawable.Drawable;
import android.graphics.Rect;
import android.support.design.widget.TabLayout;
import android.view.View;
import android.view.ViewGroup;
import android.widget.LinearLayout;
import android.widget.TextView;

Expand Down Expand Up @@ -90,6 +90,17 @@ protected void onLayout(boolean hasChanged, int left, int top, int right, int bo
super.onLayout(hasChanged, left, top, right, bottom);
insetsProvider.setTopBasedOn(this);
}

@Override
protected void onConfigurationChanged(Configuration newConfig)
{
super.onConfigurationChanged(newConfig);
if (newConfig.orientation == Configuration.ORIENTATION_PORTRAIT) {
mTabLayout.setTabGravity(TabLayout.GRAVITY_FILL);
} else if (newConfig.orientation == Configuration.ORIENTATION_LANDSCAPE) {
mTabLayout.setTabGravity(TabLayout.GRAVITY_CENTER);
}
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nit-pick. You can get rid of the mTabLayout. part since you're overriding the TabLayout class' onConfigurationChanged() method. The rest is fine. Nice and simple solution. 👍

};
this.mTabLayout.setFitsSystemWindows(true);

Expand Down